This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
Clarify Add Kafka producer and consumer Datadog metrics #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
8d6910d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a5260c7d.devportal.pages.dev |
| Branch Preview URL: | https://juham-kafka-producer-and-con.devportal.pages.dev |
juha-aiven
force-pushed
the
juham-kafka-producer-and-consumer-metrics-clarify
branch
from
df3da3f to
b9e118d
Compare
harshini-rangaswamy
previously requested changes
Dec 20, 2023
docs/products/kafka/howto/add-missing-producer-consumer-metrics.rst
Outdated
Show resolved
Hide resolved
First, remove the false claim that kafka.producer.* and kafka.consumer.* metrics are client side. Some broker-side metrics also have the prefix. Change the topic to clearly state the page is about client-side metrics.
juha-aiven
force-pushed
the
juham-kafka-producer-and-consumer-metrics-clarify
branch
from
b9e118d to
8d6910d
Compare
juha-aiven
dismissed
harshini-rangaswamy’s stale review
I changed as suggested.
juha-aiven
deleted the
juham-kafka-producer-and-consumer-metrics-clarify
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
First, remove the false claim that kafka.producer.* and kafka.consumer.* metrics are client side. Some broker-side metrics also have the prefix.
Change the topic to clearly state the page is about client-side metrics.
Why
It was unclear this page is only about client side metrics and the claim of those metrics prefixes being client-side only is not correct.